src: remove unnecessary calculation in base64.h#33839
Closed
sapics wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unnecessary calculation in base64.h#33839sapics wants to merge 1 commit intonodejs:masterfrom
sapics wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
buffer
sapics
force-pushed
the
src/simplify-base64
branch
2 times, most recently
from
28913ae to
82f408b
Compare
sapics
force-pushed
the
src/simplify-base64
branch
from
82f408b to
0a14222
Compare
Collaborator
addaleax
approved these changes
Jun 11, 2020
Collaborator
yashLadha
approved these changes
Jun 11, 2020
devnexen
approved these changes
Jun 14, 2020
jasnell
approved these changes
Jun 14, 2020
18 tasks
tniessen
approved these changes
Jun 18, 2020
Member
|
Landed in a80000e |
addaleax
pushed a commit
that referenced
this pull request
Jun 25, 2020
PR-URL: #33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
PR-URL: #33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
PR-URL: #33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary calculation in base64.h.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes